Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network mode detection #64

Open
wants to merge 1 commit into
base: 1.9.4-dcos
Choose a base branch
from

Conversation

orlandohohmeier
Copy link

Adjust the network mode detection to properly handle cases without the network-scope label as the metrics collection would otherwise fail in those cases.

Adjust the network mode detection to properly handle cases without the `network-scope` label as the metrics collection would otherwise fail in those cases.
@orlandohohmeier
Copy link
Author

orlandohohmeier commented Apr 15, 2020

@jkoelker @wavesoft would love a review from you on this one. Please note that it doesn't handle cases where the resources are reported on the executor as this would require additional requests which could degrade performance. Marathon pods launched on the host network would match this case but come with the network scope label and are thus already handled.

P.S. You will want to implement a similar detection in Edge-LB for the auto-pool feature to properly handle different network modes.

/cc @vinodkone

Copy link

@jkoelker jkoelker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic wise LGTM, I'll have to look into the test failures later, it looks like the mocks just need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants