-
Notifications
You must be signed in to change notification settings - Fork 56
Add mirroring operation for 3D CQ object and add tessellate(0.1) in the BoundBox function #134
Conversation
…t); 2. To get precise BoundBox, add tessellate(0.000001) in the BoundBox function implement......
are there any tests that go with this behavior? a test case for the tessellate function might be good as well. that woud probably belong in tests/TestCadQuery.py |
@dcowden Yes, I test the mirror functionality myself. Following your suggestion, I will work on the example and test things. For the BoundingBox function: |
That's a good question. It is not intuitive that bounding box needs a For example, how long does it take to tessellate a sphere to tolerance I think we should probably add a tolerance parameter, and default the value My rationale for that number is that it is the largest power of ten that We should use a larger default precision if it turns out that even that
|
…t); 2. To get precise BoundBox, add tessellate(0.000001) in the BoundBox function implement......
update to the upstream cadquery
…arameter into BoundingBox function, and default it as 0.1, otherwise, it's very slow when compile the docs with sphinx-build, don't know why; 3. Add a testBoundingBox function into TestCadQuery.py file...
I add a mirroring example into doc/example.rst, and also add a test function testBoundingBox into tests/TestCadQuery.py file. For the tolerance of BoundingBox, it is very slow to compile the docs with sphinx-build when I set the it to 0.001, so I default it to 0.1 at present. One more thing, the mirroring operation only works on the first object of the current CQ stack. I don't know whether it matters? Thank you for your reviewing! |
Add mirroring operation for 3D CQ object and add tessellate(0.1) in the BoundBox function
Thanks for adding the test and the documentation! |
Thanks for reviewing the pull request!