Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

feature/vector-utils #216

Merged
merged 14 commits into from
Jan 7, 2018
Merged

Conversation

fragmuffin
Copy link
Contributor

Vector and Plane utilities to allow a bit more flexibility.

@fragmuffin
Copy link
Contributor Author

I'd also like to put some utilities into cadquery.Plane to allow instantiation from Euler angles, or quaternion (and visa versa)...
But I've been sitting on this branch for a while, I thought it was time to make a PR

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 87.109% when pulling b685b39 on fragmuffin:feature/vector-utils into 2fe0e0f on dcowden:master.

Copy link
Collaborator

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcowden Do you have time to review this? I can, but you're probably better qualified.

@dcowden
Copy link
Owner

dcowden commented Jan 7, 2018

Yep, I got it!

@dcowden dcowden merged commit 1433301 into dcowden:master Jan 7, 2018
@dcowden
Copy link
Owner

dcowden commented Jan 7, 2018

I'm merging this-- @fragmuffin thanks for the contribution.
This is a ton of new functionality-- thanks for adding the tests.

The tests will be great when we move from an FreeCAD implementation to an OCC implementation later on.

@fragmuffin
Copy link
Contributor Author

No problem @dcowden
Tests have a somewhat beautiful way of simplifying code review don't they... although they're often a pain to write & maintain.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants