exposed view_vector as kwarg for SVG export

[adam-james-v]

Making a PR to address #213 .
The view vector has been removed already, so this kwarg just exposes the option to re-orient the SVG output

[coveralls]

Coverage remained the same at 91.817% when pulling e6afcca on svg_orientation_control into bb2a7b1 on master.

[dcowden]

This looks ok to me. the change to exporters.py is not reverse compatible but as that's an internal file I think that's ok.

I didn't merge because tests are failing. I've kind of lost track of where we are with that... At one point we knew some tests were failing due to in process python 2/3 stuff, but I'm not sure now

[adam-james-v]

Well, there are errors with GetSVG(), looks like it may be my fault, so I'll have to take a look

[jmwright]

the change to exporters.py is not reverse compatible but as that's an internal file I think that's ok.

@dcowden can you explain that to me? There are defaults set for the parameters, so existing scripts will run fine. Or do you mean that the SVG can't be imported properly again once exported using this option?

[jmwright]

@RustyVermeer Thanks for putting this PR together.

[dcowden]

oh @RustyVermeer you're right. when i looked at it earlier, i thought i saw a new param without a default, but i see they have defaults. I was on my phone, maybe it was cut off. sorry about that, looks good.

[adam-james-v]

I'm looking at this on my local machine. I don't want to keep making silly commits. Sorry for this, everyone. Thought this was in better shape than it is

[dcowden]

@RustyVermeer no worries! Let he who has not made silly commits complain ;) I'm thankful you're working on it given what the project pays.

[adam-james-v]

@dcowden @jmwright This PR has no conflicts.
I think it is ok to merge. The only potential concern I saw was the following:

def getSVG(shape, opts=None, view_vector=(-1.75, 1.1, 5.0))

and

def toSvg(self, opts=None, view_vector=(-1.75,1.1,5)):

both have opts. Users might be confused as to why view_vector does NOT exist in opts.

Reasoning I have for keeping them separate is:

• opts controls the width and height of the svg, which are specific settings for the document
• view_vector controls the orientation of the model itself, which is a model setting, not a document setting.

At least, that makes sense in my brain :)

[jmwright]

@RustyVermeer Thank you for this contribution. Your logic for keeping view_vector separate from opts makes sense to me. @dcowden unless you have any objections I'll go ahead and merge this.

[jmwright]

Looks good to me.

[jmwright]

Thanks again @RustyVermeer !