This repository has been archived by the owner on Feb 9, 2021. It is now read-only.
Also detect FreeCAD from conda on OSX #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bollwyvl is this ready to be merged? looks ok to me! |
|
✅ Build cadquery 1.0.56 completed (commit 07667809fa by @bollwyvl) |
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 10 10
Lines 2207 2207
=======================================
Hits 2048 2048
Misses 159 159
Continue to review full report at Codecov.
|
Closed
|
Yeah, this is already tested over on the feedstock. The line is a bit long, but it does what it says on the tin! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that freecad is installable from conda-forge on linux/osx/win, this also checks in
$PREFIX/libon OSX.Big thanks to @loooo for suggesting this simple fix over on the conda-forge PR for cadquery, where we're basically applying this patch, as well as getting FreeCAD through the conda-forge process!