Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Campaign system frontend setup & some code cleanup #64

Merged
merged 12 commits into from
Dec 5, 2022
Merged

Campaign system frontend setup & some code cleanup #64

merged 12 commits into from
Dec 5, 2022

Conversation

TevanB
Copy link
Contributor

@TevanB TevanB commented Dec 5, 2022

  • I linked our dataset to the campaign chart for some backend-sourced data visualization
  • I cleaned up some server code that was printing things for no reason

Next steps:

  • I will find a way to integrate the ML model predictions to the campaign subpage (will continue working on this branch)

@TevanB TevanB requested a review from shang8024 December 5, 2022 06:02
@TevanB TevanB requested a review from shang8024 December 5, 2022 06:25
@shang8024
Copy link
Contributor

DS_Store seems shouldn't be uploaded. Need some more time to review, will give feedback likely tomorrow morning

shang8024
shang8024 previously requested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@shang8024 shang8024 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot redirect to dashboard after signup and showing errors, I believe it's due to the change in useSignup.

client/src/hooks/useSignup.js Outdated Show resolved Hide resolved
@TevanB TevanB requested a review from shang8024 December 5, 2022 21:17
@shang8024
Copy link
Contributor

Orders table showing no charts, because I don't have the dataset on my local? is that sth we need to worry about?
4fe62e104238edcaacb4d6be7f557d0

shang8024
shang8024 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@shang8024 shang8024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't got dataset on my local so the orders chart doesn't show up and raised a server error. Others works fine.

@TevanB TevanB mentioned this pull request Dec 5, 2022
Closed
@TevanB TevanB merged commit 3807285 into main Dec 5, 2022
@FrankQQQQ

This comment was marked as duplicate.

Sign in to view
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shang8024 shang8024 shang8024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TevanB @shang8024 @FrankQQQQ