Player info scraping #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airhorns
force-pushed
the
player-info-scraping
branch
from
29d99ef
to
e60aff1
Compare
|
@airhorns just now seeing this - sorry! will look at this this weekend :) |
|
@airhorns only took me 3 months to get around to this (sorry about that), but this looks great. want to get this new release done ASAP in time for the season. I appreciate the reconfiguring of the 'page not found' error check - need to do some testing on that, because I think 'page not found' errors can very rarely be just a page loading issue as opposed to a nonexistent page issue, in which case we'd want to retry a page request. that issue might be rare enough though where your implementation (moving on after a PNF error) would be best. been a while though, so can't say for sure off the top of my head. thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a helper function for pulling in the player info for a given player id. Annoyingly, the PBPs from ESPN don't have player ids on them, and use full names, whereas the boxscores do have player ids on them, but use abbreviated names, so if you want to join the two you need to fetch this player info to get the full name for a player id. Yeesh.