Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests and fixes #15

Merged
merged 2 commits into from
Feb 28, 2022
Merged

tests and fixes #15

merged 2 commits into from
Feb 28, 2022

Conversation

ThomasWaldmann
Copy link
Collaborator

No description provided.

@ThomasWaldmann ThomasWaldmann marked this pull request as draft February 28, 2022 14:15
@ThomasWaldmann ThomasWaldmann marked this pull request as ready for review February 28, 2022 14:24
@ThomasWaldmann
Copy link
Collaborator Author

ready for now. speed tests can be added via a separate PR later, if desired.

@dcwatson
Copy link
Owner

Looks good, thanks!

I don't think speed tests are necessary. We can put something in the README maybe, but it's not like we're doing any real tuning or performance work in this wrapper, that's the domain of libdeflate.

@dcwatson dcwatson merged commit 6e9093c into dcwatson:master Feb 28, 2022
@ThomasWaldmann ThomasWaldmann deleted the tests branch February 28, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants