Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to php 8.1 or 8.2 #38

Closed
belambic opened this issue Oct 30, 2023 · 4 comments
Closed

Upgrade to php 8.1 or 8.2 #38

belambic opened this issue Oct 30, 2023 · 4 comments

Comments

@belambic
Copy link

belambic commented Oct 30, 2023

PHP 8.0 is reaching EOL on 26th November 2023, so it would be nice to get the image upgraded.

I've installed our environment on a test EC2 instance running debian and PHP 8.2 and everything looks good so far, but I haven't done a full test of all our contrib modules yet.

Also it seems like php-mcrypt has been brought back into the fold maybe, because I was able to do a regular install of the module instead of jumping through the pecl/pear hoops we had to do before.

@alberto56
Copy link
Contributor

Here is a pull request which uses version 8.1 of the community Drupal image as a base.

If tests pass this should be good to go!

I prefer 8.1 at this point for Drupal 7, and even Drupal 10, because PHP 8.2 introduced a deprecation notice for classes which use properties which are not explicitly defined; and a quick glance at several contrib modules shows that many have not included this change yet.

@alberto56
Copy link
Contributor

Tests are passing at #39

I will merge and report back when the image with PHP 8.1 is published.

@alberto56
Copy link
Contributor

This now works at:

docker pull dcycle/drupal:7php8 && docker run --rm dcycle/drupal:7php8 /bin/bash -c 'php -v'
...
PHP 8.1.25 (cli) (built: Oct 28 2023 02:32:47) (NTS)

@belambic
Copy link
Author

belambic commented Nov 3, 2023

Thanks Albert, this seems to be working well, we're testing it alongside an 8.2 ec instance and both are fine so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants