Add contact form #3
Conversation
index.html
Outdated
| <textarea name="message" cols="30" rows="10" maxlength="500"> | ||
| Enter text here</textarea |
There was a problem hiding this comment.
-
Great job 👍 💯 with
textarea. But it should be better for yourEnter text heretext to be in thePlaceholderproperty. So this will not affect the user when he wants to write a message. -
And all your
textareashould have therequiredproperty to not send empty message.
index.html
Outdated
| <form | ||
| action="https://formspree.io/f/contact-form" | ||
| method="post" | ||
| class="contact-form" | ||
| > |
There was a problem hiding this comment.
- Good job 💯 👍 with your
Formspree. So, I noticed that the user can't send a message after completing all fields and clicking theGet in touchbutton. I think you should create an account and you'll have auniquekey that you will use in:action="https://formspree.io/f/form_id".
After sending the message this is the output:
There was a problem hiding this comment.
Hi @dd-obua and @Lusindiso
Good job so far! I know you have worked hard on making this milestone But There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight 🍾
- All linters are passing ✔️
- Good commit history ✔️
- Your design looks good 💯 ✔️
- Good PR description ✔️
Required Changes ♻️
- Kindly check comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Thanks, I will look into it.
…On Tue, Mar 22, 2022, 6:29 PM anderson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In index.html
<#3 (comment)>:
> + <form
+ action="https://formspree.io/f/contact-form"
+ method="post"
+ class="contact-form"
+ >
- Good job 💯 👍 with your Formspree. So, I noticed that the user
can't send a message after completing all fields and clicking the Get
in touch button. I think you should create an *account* and you'll
have a unique key that you will use in: action="
https://formspree.io/f/form_id".
—
Reply to this email directly, view it on GitHub
<#3 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVNN55FHHN462XIS2W7O5W3VBHROPANCNFSM5RK2CWUQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Hello @dd-obua 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉 🎉 🎉 🎉 🎉,
Cheers and Happy coding!👏👏👏
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this project, we have added the contact form to my portfolio project.
Included are: