Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add new variant documentation in tab #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

genixxavier
Copy link
Contributor

Summary

Add new variant documentation in tab called tertiary and onClick was changed to onChange, to solve this warning:
Provided a 'checked' prop to a form field without an 'onChange' handler.

Task

OK-100

Affected sections

  • src/modules/docs/navigation/TabsCustom.tsx
  • docs/navigation/tabs.mdx
  • package.json

How did you test this change?

Manual

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 4:43pm

@genixxavier genixxavier added the documentation Improvements or additions to documentation label Feb 8, 2024
Copy link
Contributor

@arielsrodriguez arielsrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, we would just have to wait for the new DS release to be made, since it provisionally has the sandbox compilation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants