Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return body of single-part HTML message as HTML, not text #101

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

pepamartinec
Copy link
Contributor

Return content of single-part message in $message->getHtmlBody() when content type of message is HTML.

@@ -218,7 +225,11 @@ public function getBodyText()
}

// If message has no parts, return content of message itself.
return $this->getDecodedContent($this->keepUnseen);
if ($this->getSubtype() != 'HTML') {
Copy link

@Lewiscowles1986 Lewiscowles1986 Sep 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leading from the existing examples in the code

        if ($this->getSubtype() == 'PLAIN') {
            return $this->getDecodedContent($this->keepUnseen);
        }

would surely be a more consistent way of expressing?

@Slamdunk Slamdunk changed the base branch from master to develop September 29, 2017 08:28
@Slamdunk Slamdunk merged commit 3dd6921 into ddeboer:develop Sep 29, 2017
Slamdunk added a commit that referenced this pull request Sep 29, 2017
Slamdunk added a commit that referenced this pull request Sep 29, 2017
@Slamdunk Slamdunk added the bug label Sep 29, 2017
@Slamdunk Slamdunk added this to the 1.0 milestone Sep 29, 2017
@Slamdunk
Copy link
Collaborator

@Joker806 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants