Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: use local Dovecot installation #170

Merged
merged 8 commits into from
Sep 22, 2017

Conversation

Slamdunk
Copy link
Collaborator

@Slamdunk Slamdunk commented Sep 22, 2017

  • Travis: move to Dovecot pure testing
  • PHP: bump to ^7.0
  • Travis: test against PHP 7.0, 7.1, 7.2
  • Remove and ignore composer.lock: catch forward compatibility breaks early
  • Autoload tests only on dev
  • PHPUnit: bump to ^5.7
  • Tests: fix failures to ease this PR, new PR will come to fix the tests
  • Doc: update local testing guide

@Slamdunk Slamdunk changed the base branch from master to develop September 22, 2017 07:56
Copy link
Owner

@ddeboer ddeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

There are still four failing test cases, of which two have to do with encoding issues. Do you have any idea why Ddeboer\Imap\Tests\MessageTest::testKeepUnseen and Ddeboer\Imap\Tests\MessageTest::testDelete no longer work?

@Slamdunk
Copy link
Collaborator Author

There are still four failing test cases

Yes, I did it on purpose: first fix the test environment, and only then fix the tests

of which two have to do with encoding issues

Encoding is a nightmare; we'll need a lot of test cases and dedicated tests. I'll work on them only after everything else because they deserve special attention

Do you have any idea why Ddeboer\Imap\Tests\MessageTest::testKeepUnseen and Ddeboer\Imap\Tests\MessageTest::testDelete no longer work?

  • testKeepUnseen no idea; it seems dovecot always marks retrieved messages as seen
  • testDelete is easy, delete only mark the mail as deleted but not deletes it, we need to call $mailbox->expunge() to actually delete them.

@Slamdunk
Copy link
Collaborator Author

@ddeboer I consider this PR complete, but I see you requested some changes through the review, without specific changes pinpointed. Are there any more changes needed, or can we merge it?

After this one, a lot PR will follow:

  1. Coding-standard integration
  2. imap_alerts and imap_errors integration into the exception messages
  3. Deep encoding testing
  4. New features requested by issues/PRs

@ddeboer
Copy link
Owner

ddeboer commented Sep 22, 2017

I was referring to the failing test cases. Do you want to fix them in separate PRs?

@Slamdunk
Copy link
Collaborator Author

Yes, I already am, because other users can better track what happened and why:

  1. One PR to move to Dovecot, and how
  2. One PR to analyze and fix the errors

@ddeboer ddeboer merged commit c3507cb into ddeboer:develop Sep 22, 2017
@Slamdunk Slamdunk deleted the travis_dovecot branch September 25, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants