New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchCondition: __toString() -> toString() #187

Merged

Slamdunk merged 2 commits into ddeboer:develop from Slamdunk:search_refactor

Sep 26, 2017

Collaborator

Slamdunk commented Sep 26, 2017 •

edited

Loading

Reference: http://phpsadness.com/sad/14

Introduce Search\ConditionInterface
Typehint against Search\ConditionInterface
Move existing search conditions from __toString() to toString()
Typehint DateTimeInterface istead of DateTime

BC Breaks

Signature of Ddeboer\Imap\Search\AbstractCondition changed.
Introduced Ddeboer\Imap\Search\ConditionInterface to let users implement their own Conditions without inheritance.


          Added Search\ConditionInterface

6ff5c12

Slamdunk added awaiting author updates enhancement labels

Slamdunk added this to the 1.0 milestone


          Implement Search\ConditionInterface usage

cdd7a46

Slamdunk changed the title ~~[WIP] Search: __toString() -> toString()~~ [WIP] SearchCondition: __toString() -> toString()

Slamdunk added BC break and removed awaiting author updates labels

Slamdunk changed the title ~~[WIP] SearchCondition: __toString() -> toString()~~ SearchCondition: __toString() -> toString()

Slamdunk merged commit c53fdf1 into ddeboer:develop

Slamdunk deleted the search_refactor branch

September 26, 2017 12:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC break enhancement