Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💚 Upgrade GitHub actions/checkout@v1 --> v2 #5

Merged
merged 2 commits into from
Jan 10, 2020
Merged

💚 Upgrade GitHub actions/checkout@v1 --> v2 #5

merged 2 commits into from
Jan 10, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 9, 2020

@cclauss cclauss requested a review from ddelange as a code owner January 9, 2020 23:08
@ddelange
Copy link
Owner

ddelange commented Jan 9, 2020

Hi @cclauss, thanks for this, didn't know they released v2!

Somehow, push event wasn't triggered for
27eb5a6. Maybe it's good practice to add pull_request as well to get CI running? Haven't seen this happen before...

@ddelange ddelange changed the title Upgrade GitHub actions/checkout@v1 --> v2 💚 Upgrade GitHub actions/checkout@v1 --> v2 Jan 10, 2020
ddelange
ddelange approved these changes Jan 10, 2020
View reviewed changes
Copy link
Owner

@ddelange ddelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💥

@ddelange ddelange merged commit 74f5a85 into ddelange:master Jan 10, 2020
@cclauss cclauss deleted the patch-1 branch January 10, 2020 09:41
ddelange added a commit that referenced this pull request Jan 23, 2020
@ddelange
Merge branch 'master' of https://github.com/ddelange/pipgrip into fixes
445a3d5 
* 'master' of https://github.com/ddelange/pipgrip:
  ➕ Add backports for enum and typing modules (#7)
  💚 Upgrade GitHub actions/checkout@v1 --> v2 (#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelange ddelange ddelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @ddelange