-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindVexCL.cmake script #20
Conversation
How will user find the findvexcl script? Besides, the scripts only looks into standard include paths plus a user-defined path. Is this better than setting include_dirs manually? |
It was intended for the user to copy it into their project - because there's no real standard way of finding it... unless we copy it into /usr/share/cmake/Modules (but I do not think this is recommended - I have only noticed one project doing this on my system). This allows for some shortcuts once you have FindVexCL.cmake in your module path:
These sort of checks need to be done manually otherwise - I don't know if this would best live in VexCL, but I find it generally useful. |
When VexCL is installed through the CMake install target, the installation path could be hardcoded into FindVexCL.cmake using the |
I think the intention is to copy the FindVexCL.cmake into ones project, same as we do with FindOpenCL.cmake. Hardcoded path would not help here. |
For the same reason I am not sure if FindVexCL.cmake should be installed with the rest of the files. |
I agree, yes. Thanks! |
I guess it doesn't have to be installed - but it is in /usr/share/vexcl - where the examples live as well. Perhaps add a CMakeLists option to disable it? |
Lets keep it with the examples then |
I wrote a simple cmake script for finding the include headers - and it gets installed to /usr/share/vexcl/cmake/Modules.
Maybe useful for developers.