Implement vector and multivector iterators with boost::iterator_facade #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the iterators to really comply with the std::random_access_iterator_tag. Also should solve issue #90.
|
@ddemidov, compilation works but tests fail on vector_arithmetics and multivector_arithmetics. Don't know if it's related. Maybe a new issue? |
|
Can you provide an output for a failing test? |
|
Ah, found those in another thread. If you have same errors as before, it looks like a bug in your OpenCL implementation: Can you also show the output of |
|
Error output: https://gist.github.com/sebsjoberg/8674911 |
|
It does look like a bug in Apple's OpenCL. Does 091471c work? |
|
No, unfortunately not. The same error but the constant has the value 4.2100000000000001e+01 in the kernel now. |
ddemidov
added a commit
that referenced
this pull request
Jan 28, 2014
Implement vector and multivector iterators with boost::iterator_facade
|
I think I know the reason. Will push the fix to the master branch in a minute. |
ddemidov
added a commit
that referenced
this pull request
Jan 28, 2014
size_t and ulong are different types on MacOSX, so no overload for max(size_t, ulong) could be found. See discussion in #91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the iterators to really comply with the
std::random_access_iterator_tag. Also should solve issue #90.@sebsjoberg, could you please check if this works on Mac OS X?