-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement vector and multivector iterators with boost::iterator_facade #91
Conversation
This should make the iterators to really comply with the std::random_access_iterator_tag. Also should solve issue #90.
@ddemidov, compilation works but tests fail on vector_arithmetics and multivector_arithmetics. Don't know if it's related. Maybe a new issue? |
Can you provide an output for a failing test? |
Ah, found those in another thread. If you have same errors as before, it looks like a bug in your OpenCL implementation:
Can you also show the output of |
Error output: https://gist.github.com/sebsjoberg/8674911 |
It does look like a bug in Apple's OpenCL. Does 091471c work? |
No, unfortunately not. The same error but the constant has the value 4.2100000000000001e+01 in the kernel now. |
Implement vector and multivector iterators with boost::iterator_facade
I think I know the reason. Will push the fix to the master branch in a minute. |
size_t and ulong are different types on MacOSX, so no overload for max(size_t, ulong) could be found. See discussion in #91.
This should make the iterators to really comply with the
std::random_access_iterator_tag
. Also should solve issue #90.@sebsjoberg, could you please check if this works on Mac OS X?