Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solr config update tip, fixes #15 #27

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Add Solr config update tip, fixes #15 #27

merged 1 commit into from
Jun 12, 2023

Conversation

gitressa
Copy link
Contributor

@gitressa gitressa commented Jun 12, 2023

The Issue

Fixes

How This PR Solves The Issue

Adds documentation on how to fix outdated Solr config files message.

Also updates the "Alternate Core Name" section, the first step (1. Remove the #ddev-generated at the top of the file.) isn't necessary, it seems?

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay changed the title Add Solr config update tip Add Solr config update tip, fixes #15 Jun 12, 2023
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great, just the one question about why you removed #ddev-generated notice.

README.md Show resolved Hide resolved
@rfay
Copy link
Member

rfay commented Jun 12, 2023

If you don't remove the #ddev-generated then the file will be recreated with the default file on ddev restart.

@gitressa
Copy link
Contributor Author

gitressa commented Jun 12, 2023

I removed it because after creating the file .ddev/docker-compose.solr-env.yaml, adding this:

services:
  solr:
    environment:
    - SOLR_CORENAME=somecorename

and restarting DDEV, at no point do I see a line saying #ddev-generated, so I removed that first line ...

Or is that first line about something else?

README.md Show resolved Hide resolved
@rfay rfay merged commit e90923b into ddev:main Jun 12, 2023
@gitressa
Copy link
Contributor Author

Great, thanks!

@rfay
Copy link
Member

rfay commented Jun 12, 2023

Thanks for the contribution and for keeping your eye on this repo. You know and use solr far more than I do, and it needs knowledgable folks following it.

@gitressa
Copy link
Contributor Author

You're welcome, I am glad I could help. It's a privilege to assist you with DDEV, it's an amazing web developer tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants