Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention needed dependencies in README #78

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Mention needed dependencies in README #78

merged 1 commit into from
Dec 12, 2022

Conversation

lolautruche
Copy link
Contributor

Ref #76 #46

@lolautruche lolautruche mentioned this pull request Dec 12, 2022
Merged
rfay
rfay requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I was going to add it into the other PR, but this was more responsive to user's request, which is great.

Pretty sure there's some context trouble with this here...
Mention_needed_dependencies_in_README_by_lolautruche_·_Pull_Request__78_·_platformsh_ddev-platformsh

@lolautruche
Copy link
Contributor Author

I agree, but this is not related to this PR.
Furthermore, I think this is more part of usage than install.

rfay
rfay approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, it was what you wanted, sorry, looked to me like an edit in the wrong place or something.

ddev-platformsh_README_md_at_98f10db814a3284b74ba1f2f0c1b5f458959f493_·_platformsh_ddev-platformsh

@rfay rfay merged commit ae0bd96 into ddev:main Dec 12, 2022
@lolautruche lolautruche deleted the add-dependencies-readme branch December 13, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolautruche @rfay