Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the add-on work with DDEV v1.23.0 #28

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix: make the add-on work with DDEV v1.23.0 #28

merged 3 commits into from
Apr 22, 2024

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

  • Service should mount ddev-global-cache (see this PR)
  • Update README.md (after changes in ddev/ddev-redis)
  • Fix an error from docker-compose in DDEV v1.23.0 (use float as a workaround):
* error decoding 'services[redis].deploy.resources.limits.cpus': unexpected value type int for cpus

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev
Copy link
Member Author

@seebeen, I'm going to merge this PR and make a new release.
Only because it is official and people who are counting on it are probably waiting.

@stasadev stasadev added this pull request to the merge queue Apr 22, 2024
@stasadev stasadev removed this pull request from the merge queue due to a manual request Apr 22, 2024
@stasadev stasadev merged commit 04f1e0a into master Apr 22, 2024
1 check passed
@stasadev stasadev deleted the 20240419_stasadev_update_config branch April 22, 2024 19:09
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@stasadev stasadev mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stasadev