-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use redis:6-bullseye to support old systems, update GitHub test workflow #17
Use redis:6-bullseye to support old systems, update GitHub test workflow #17
Conversation
From this comment:
As a result, Redis will not receive updates, this is a minus, but there is a plus, because it will not suddenly break in the future. So at least for now this change will make this add-on stable. People who need a different Redis image can:
|
Alternatively, I can add a note about I still haven't decided which is better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Randy Fay <randy@randyfay.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great.
The Issue
Per support ticket in https://discord.com/channels/664580571770388500/1134183410773008554 this addon fails to start with Docker 20.10.7 (released on 2021-06-02) on Ubuntu 20.04.
The actual error is:
Full `ddev logs -s redis`
This issue is caused by the migration from Debian
bullseye
tobookworm
base for theredis
image.How This PR Solves The Issue
This PR replaces
redis:6
withredis:6-bullseye
. We can support a wider range of systems that pull this add-on using theredis:*-bullseye
tag.This is NOT a long term solution, as the
bullseye
tags may not have updates in the future.Manual Testing Instructions
Automated Testing Overview
GitHub actions use the updated images, so this issue was not detected here.
Related Issue Link(s)