Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional --redis-tag flag, fixes #1 #24

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jul 17, 2024

The Issue

How This PR Solves The Issue

Adds optional --redis-tag value flag, that creates .ddev/.env.redis file with REDIS_TAG="value".

Manual Testing Instructions

Install add-on using DDEV binary from:

ddev add-on get https://github.com/ddev/ddev-redis/tarball/20240717_stasadev_optional_version
ddev dotenv set .ddev/.env.redis --redis-tag=7
ddev restart

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev force-pushed the 20240717_stasadev_optional_version branch from ab6497b to 79facaa Compare July 17, 2024 13:27
@rfay
Copy link
Member

rfay commented Aug 2, 2024

Please take a look and make ready for review when ready, thanks.

@stasadev
Copy link
Member Author

stasadev commented Aug 2, 2024

Sure, but first I need to finish the parent task and it should probably be ready next week.

@stasadev stasadev changed the title Add optional $REDIS_VERSION, fixes #1 Add optional $DDEV_REDIS_VERSION, fixes #1 Aug 30, 2024
@stasadev stasadev marked this pull request as ready for review August 30, 2024 16:46
@stasadev stasadev changed the title Add optional $DDEV_REDIS_VERSION, fixes #1 Add optional --redis-tag flag, fixes #1 Sep 16, 2024
@rfay
Copy link
Member

rfay commented Sep 23, 2024

Works great for me, can be pulled when we're ready.

@stasadev stasadev merged commit ce69968 into main Oct 17, 2024
2 checks passed
@stasadev stasadev deleted the 20240717_stasadev_optional_version branch October 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants