Technology selection #1
Comments
|
After some initial investigation, I've come to the conclusion that Electron, as initially suggested by @rickmanelius, will suit our needs fine. My only concern, however, is that the base bundle size is 136MB. The code on top will be 5-10 megs, but in a worse case scenario we could potentially have a UI alone that weighs in at 200 megs! |
|
As per a conversation with me and @andrew-c-tran yesterday, we're looking at Electron for the packaging as described above with React as the framework to build. We've had some concerns about this because of some previous legal issues, but it appears the modified license is less onerous and Apple + Microsoft now allow their teams to use React. Still, we will want one final pass through by legal. I'll assign this to me to take that on. |
|
After more investigation, it appears using Electrino, we can reduce the payload size for Windows and OSX platforms to under a meg or two before image assets are added to the UI. the Linux binaries, however, are still going to weigh a few hundred megs. |
|
@andrew-c-tran Here's the draft I've queued up for legal. Can you sanity check for any inaccuracies at a tech level? I fully understand that you're not a lawyer and not necessarily the person to review this with that level of scrutiny. https://docs.google.com/document/d/1PxmGOp71qRG34539itWu3uLPpcKSIloT9DRYDEISl8I/edit |
|
Got a thumbs up from @andrew-c-tran in a direct 1x1 Slack. Just need approval from @sgrandchamp now and I'll send to Donyelle. |
|
@rickmanelius requested access to the doc |
|
@sgrandchamp Sorry about that. I just gave you permission! |
|
Got the thumbs up to follow-up from Steve. Emailing Donyelle now! |
|
Email sent! |
|
A few articles/discussions have popped up that are worth referencing (thanks, @cyberswat, for surfacing them).
Summarizing without having read ALL the gory details:
|
|
Here's a counter article: |
|
When do we expect to hear back from Donyelle? My thought process is that the moment facebook actually enforces their license stipulation and revokes someone's license, it'll be front page on every tech blog and people will abandon React worldwide overnight. They've got one shot to use it, unless they're very clearly fighting a patent troll in which case it makes their stance even stronger. The chances of us being the one shot ever that FB gets to bully is virtually zero i'd think. |
|
Hi @andrew-c-tran:
|
|
@andrew-c-tran FYI. In the convo with @sgrandchamp and @cyberswat, our preference is to stick with React. We have a call w/Donyelle in 5 minutes as a final sanity check and (hopefully) we can then proceed. |
|
After much deliberation and a discussion with legal, we've concluded that the gains in using React (larger community, faster time to market, etc) outweigh the risks, which are largely edge case and are not without ways around it (e.g. fork react, replace with preact/angular, etc) should it ever become an actual problem for the business. |
|
Sweeeeeeet
…On Aug 21, 2017 1:35 PM, "Rick Manelius" ***@***.***> wrote:
After much deliberation and a discussion with legal, we've concluded that
the gains in using React (larger community, faster time to market, etc)
outweigh the risks, which are largely edge case and are not without ways
around it (e.g. fork react, replace with preact/angular, etc) should it
ever become an actual problem for the business.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIi5a7AQfSdZDCxsEObge0Q6VtQprOrOks5sadv9gaJpZM4OzxhY>
.
|
|
@andrew-c-tran It looks like we're good to go unless you have any follow-up questions re:Electron and React as the two major underlying technologies that we'll use for our UIs. |
|
Just noting that an open item on this might be a conversation between @andrew-c-tran and @beeradb to review any implications on the connection with Golang on the backend. Then let's get this closed out. |
|
Upon further investigation today, I don't see how we can pull this wrapper off without electron, and it's by far the most elegant solution. A huge impediment I found is that the file system is sandboxed via browser safety protocol (which makes sense, javascript in the wild should be able to see your filesystem). This makes things like 'ddev config' require the end user to have to type in the path into a box, which is absolutely not ideal. Electron exposes the filesystem, overriding this issue. Secondly, electron having a bundled chrome engine means that cross platform testing should be virtually identical. |
|
At this stage, there isn't anything else actionable for this ticket. We will continue to test/benchmark memory/CPU footprints, but short of anything major coming up, it will not influence our selection in the short term. |
|
Found this article and thought it was very helpful in deliniating the differences in the copyright/usage and patent grants. https://blog.fossa.io/dont-over-react-to-the-facebook-patents-license-629f708f2221 |
…mework Issue 32 initial testing framework Former-commit-id: 402e3ae
Ultimately, we need to select our implementation strategy for a native app. This needs to consider OS compatibility, flexibility, long term support from the community, license compatibility, development speed gains, etc.
The text was updated successfully, but these errors were encountered: