-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app from CMS distribution #14
Comments
It sounds like this is where there is some question or confusion over (1) the intention and (2) value of this feature. I'll attempt to break it into two pieces in my next comment, but I know this is in active conversation and I wanted to highlight that my attention is now on this. |
IntentionWhile this may not be officially documented in this repo or within our docs, there is an assumption that the UI will provide an easier onboarding and ongoing usage for end-users that are not as familiar or comfortable on the command line. To that end, when it seems useful without adding significant technical debt, I would prefer to allow them to be as functional as possible from a site-building perspective without having to go to the terminal. Additionally, those that may be completely new to WordPress or Drupal may find the barrier to entry to download and place the codebase. Also note situations like Kalabox's integration w/Pantheon, which essentially allows them to trigger Pantheon to spin up a site of a specific type and then pull it down. I'm rambling a little, but summarizing:
Value
To that end, if we're saying that packaging them within the GUI doesn't make sense... I'm not opposed to pivoting the storage to a trigger to download and then keeping a cached copy locally (perhaps in ~/.ddev) so we don't get wound up around whether or not it's delivered with the installation. |
Work is blocked until a decision is made on #24 |
Unblocked #24. Updated to actionable! |
Regarding the style/design of this element, we had a discussion in #8 that would remove it from the upper right as a button and instead show up as the first card before the active sites. There were two motivating factors: 1) We will replace the button in the upper right of the screen with a menu and 2) when there are no sites active, we wanted a more prominent call-out. As for card appearance, we can keep the modal and make the default card a simple blue background with a white plus in the middle. Upon hover it would have the dark blue background. Upon click it would bring up the current modal. As for the modal appearance, we currently have the following options:
I think we need to rethink this because this works for existing sites but doesn't really make sense for a new site from a distribution. I imagine two flows. Specify an Existing Codebase
Quickstart From Distribution
The downside of this approach is that we may need to have an initial question to only show info related to the specific use case. Alternatively, we could provide the user a choice on the "Add" card by providing two buttons. Title: "Add a New Site" I need to think through the text strings, but this would highlight the two use cases. |
blocked by #24 - PR ready, needs approval before we can move forward with this |
@andrew-c-tran When you have a moment, can you point me to the PR to review this one? I'm perhaps a little dense... |
It looks like from the reviews starting here #62 (review) that there is a bit of code/test cleanup before we merge. |
v0.1.0 accepted and released, closing issue |
What happened (or feature request):
Feature request
What you expected to happen:
ddev config
uses known docroot and app type values.ddev start
is triggered.ddev start
completes, the user is prompted with a link to the site.The text was updated successfully, but these errors were encountered: