fix: typo in the HTTP port, for #31 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think the tests failed due to move to official status and requiring #34 to be merge. I just did that so the tests should pass now. |
stasadev
force-pushed
the
20240605_stasadev_http_port
branch
from
875df87
to
b8429d4
Compare
|
I did this in the repo settings to enable the button for rebase:
And rebased the branch, it should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I noticed extra
:which breaks the HTTP URL.How This PR Solves The Issue
Removes it.
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes