Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ddev.com to astro 4.5, fixes #165, fixes #156, fixes #155, fixes #157, fixes #159 #181

Merged

Conversation

bmartinez287
Copy link
Collaborator

@bmartinez287 bmartinez287 commented Mar 29, 2024

The Issue

Updates Astro to 4.5 and it's dependencies.

The main issues here were:

  1. Figure out why glob.sync won't work and if it does not find a replacement for glob.
  2. astro-imagetools did not work with the latest version of Astro so we had to switch back to their native Images package which I believe was not released when we went for imagetools.

Glob does the website search and it checks the author's name against the MD name field.

Copy link

cloudflare-workers-and-pages bot commented Mar 29, 2024

Deploying ddev-com-front-end with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f9641d
Status: ✅  Deploy successful!
Preview URL: https://04f9fbf1.ddev-com-front-end.pages.dev
Branch Preview URL: https://20240329-bmartinez-updated-a.ddev-com-front-end.pages.dev

View logs

@bmartinez287 bmartinez287 changed the title Updated ddev.com website to the latest astro release. Updates ddev.com to the latest astro release. Mar 29, 2024
@bmartinez287 bmartinez287 changed the title Updates ddev.com to the latest astro release. Updates ddev.com to astro 4.5 Mar 29, 2024
@bmartinez287
Copy link
Collaborator Author

bmartinez287 commented Mar 29, 2024

Rss and json feeds are also broken and need to be updated.

@bmartinez287 bmartinez287 force-pushed the 20240329_bmartinez_updated_astro_and_dependencies branch from 8fe90ff to 9c2734e Compare March 31, 2024 15:50
@rfay
Copy link
Member

rfay commented Mar 31, 2024

Just a note to say that your maintenance of this is very much appreciated!

@rfay
Copy link
Member

rfay commented Mar 31, 2024

Will this PR obsolete all the pending dependabot dependency PRs?

@bmartinez287
Copy link
Collaborator Author

bmartinez287 commented Mar 31, 2024

Yeah, This should take care of all those updates/warnings.
I started with the largest packages and will work my way down.

@bmartinez287 bmartinez287 requested a review from rfay April 3, 2024 01:55
@bmartinez287 bmartinez287 marked this pull request as ready for review April 3, 2024 01:55
@bmartinez287
Copy link
Collaborator Author

This should be ready for review.
It's unfortunate that I could not find an updated version of the Astro-image tools. But we can use Astro native images and pictures even if it does not have all the additional options.

Upcoming changes:

  • Astro-image is removed since they don't have a compatible release and we move towards using Astro native image and picture component.
  • base64-img has all kinds of security warnings on its dependencies and the latest release was 6 years ago hence we move towards node-base64-image which seems to do the same. This one package had 7 issues that drove dependabot crazy.
  • the glob package import was updated so search and other elements that use it should work as expected.

@bmartinez287
Copy link
Collaborator Author

Closes: #165, #156, #155, #157, #159

@rfay rfay changed the title Updates ddev.com to astro 4.5 Updates ddev.com to astro 4.5, fixes #165, fixes #156, fixes #155, fixes #157, fixes #159 Apr 3, 2024
@rfay
Copy link
Member

rfay commented Apr 3, 2024

It's unfortunate that I could not find an updated version of the Astro-image tools. But we can use Astro native images and pictures even if it does not have all the additional options.

Could you say more about what this means? Are we talking about the tools the build the site? Or testing tools?

@bmartinez287
Copy link
Collaborator Author

bmartinez287 commented Apr 3, 2024

Neither, Astro-image tool is a collection of tools for optimizing images. An npm package that improves images on the website.
https://www.npmjs.com/package/astro-imagetools
It served a bigger purpose before Astro rolled its native image component.
The biggest item we lose is the responsive source set.
It looked like that
Screenshot 2024-04-03 at 12 05 16 AM
and now it looks like this.
Screenshot 2024-04-03 at 12 06 34 AM

Not the end of the world, but it was a nice thing to have. It gave a Drupalish image vibe haha.

The GitHub repo has no commits in 8 months so the maintainer might have moved on.
https://github.com/RafidMuhymin/astro-imagetools

@rfay rfay force-pushed the 20240329_bmartinez_updated_astro_and_dependencies branch from 64c4374 to 3f9641d Compare April 3, 2024 16:11
@rfay
Copy link
Member

rfay commented Apr 3, 2024

Rebased.

@bmartinez287
Copy link
Collaborator Author

I was thinking about merging this later today. Thoughts?
It seems like it covers all the basics though something may pop later.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! Please manually review the most sensitive parts and then go ahead and pull when you're ready.

@bmartinez287 bmartinez287 merged commit 5aeda31 into main Apr 4, 2024
2 checks passed
@bmartinez287 bmartinez287 deleted the 20240329_bmartinez_updated_astro_and_dependencies branch April 4, 2024 19:03
@rfay
Copy link
Member

rfay commented Apr 4, 2024

🚀 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants