Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide token-authentication for go-github #3586

Closed
rfay opened this issue Feb 9, 2022 · 0 comments
Closed

Provide token-authentication for go-github #3586

rfay opened this issue Feb 9, 2022 · 0 comments
Milestone

Comments

@rfay
Copy link
Member

rfay commented Feb 9, 2022

The go-github library used for ddev get can overrun the github api limits in some situations, especially testing, and especially colima teting. This is explained in https://github.com/google/go-github#authentication and the workaround is to provide a PAT, which will make a big difference for tests. This needs to go in to prevent needless test failures.

@rfay rfay added this to the v1.19 milestone Feb 9, 2022
rfay added a commit to rfay/ddev that referenced this issue Feb 11, 2022
@rfay rfay closed this as completed in 9f24e7a Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant