feat: replace MailHog with Mailpit, provide global router port configuration, fixes #4827, fixes #5220, for #4701 #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
rfay
force-pushed
the
20230831_replace_mailhog_with_mailpit
branch
from
cd496af
to
318429d
Compare
6 tasks
This was referenced Sep 1, 2023
stasadev
approved these changes
Sep 1, 2023
|
|
||
| # host_mailhog_port: "8025" | ||
| # The mailhog port is not normally bound on the host at all, instead being routed | ||
| # host_mailpit_port: "8025" |
There was a problem hiding this comment.
This is probably the least used configuration because this is the first time I see it.
There is no documentation for it (except for DDEV_HOST_MAILPIT_PORT) and no such option in ddev config.
There was a problem hiding this comment.
Added the doc. Agreed it's mighty obscure.
|
Confirmed, works OOTB on Drupal 10. TestService
$ ddev -v
ddev version v1.22.1-58-g3a427fd30
mkdir my-drupal10-site
cd my-drupal10-site
ddev config --project-type=drupal10 --docroot=web --create-docroot
ddev start
ddev composer create drupal/recommended-project
ddev composer require drush/drush
ddev drush site:install --account-name=admin --account-pass=admin -y
ddev drush uli
ddev launch
Status
|
rfay
force-pushed
the
20230831_replace_mailhog_with_mailpit
branch
from
3a427fd
to
7f53627
Compare
mattstein
approved these changes
Sep 4, 2023
mattstein
changed the title
|
I changed mailpit-port to mailpit-http-port, etc. |
Co-authored-by: Matt Stein <m@ttste.in>
…lthough deprecated
rfay
force-pushed
the
20230831_replace_mailhog_with_mailpit
branch
from
4d5fa38
to
81418fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
All I wanted to do was retire the fork. But it still didn't have a decent arm64 download. So I just kept going. Used up my day!
Manual Testing Instructions
Use
ddev launch -mas usualAutomated Testing Overview
Added TestMailpit - there was nothing previously
Release concerns
This invalidates https://github.com/tyler36/ddev-mailpit although it's possible it would still be compatible.