feat: accept port in `ddev launch`, for #5525 #6024

stasadev · 2024-03-27T17:22:04Z

The Issue

feat: launch port global custom command helper, fixes #5518 #5525

I added an example in #5986 to run ddev launch with a specific port:

# Open your project’s base URL using a specific port
ddev launch $DDEV_PRIMARY_URL:3000

But this never actually worked:

DDEV_DEBUG=true ddev launch $DDEV_PRIMARY_URL:3000
FULLURL https://d10.ddev.site/:3900

$DDEV_PRIMARY_URL is not expanded because it is not available on the host side and $DDEV_PRIMARY_URL:3000 and :3000 are the same thing.

ddev launch $DDEV_PRIMARY_URL:3000 only works if it is run in another DDEV custom script.

How This PR Solves The Issue

Adds actual support to launch ports.

Manual Testing Instructions

ddev debug fix-commands

$ DDEV_DEBUG=true ddev launch :3000
FULLURL https://d10.ddev.site:3000

$ DDEV_DEBUG=true ddev launch :3000/test
FULLURL https://d10.ddev.site:3000/test

See a tip for HTTP to HTTPS redirect at https://ddev--6024.org.readthedocs.build/en/6024/users/usage/commands/#launch

$ DDEV_DEBUG=true ddev launch :8025
HTTP may redirect to HTTPS in your browser
See https://ddev.readthedocs.io/en/stable/users/usage/commands/#launch
FULLURL http://d10.ddev.site:8025

$ DDEV_DEBUG=true ddev launch :8026
FULLURL https://d10.ddev.site:8026

Automated Testing Overview

Release/Deployment Notes

github-actions · 2024-03-27T17:25:41Z

Download the artifacts for this pull request:

See Testing a PR.

penyaskito

Tested this on gitpod and worked as expected.

penyaskito · 2024-03-27T21:05:11Z

cmd/ddev/cmd/commands_test.go

@@ -347,6 +348,7 @@ func TestLaunchCommand(t *testing.T) {
 		"nested/path":                      app.GetPrimaryURL() + "/nested/path",
 		"/path-with-slash":                 app.GetPrimaryURL() + "/path-with-slash",
 		app.GetPrimaryURL() + "/full-path": app.GetPrimaryURL() + "/full-path",
+		":3000":                            primaryURLWithoutPort + ":3000",


Should we add another test for ":3000/test"?

Suggested change

":3000": primaryURLWithoutPort + ":3000",

":3000": primaryURLWithoutPort + ":3000",

":3000/test": primaryURLWithoutPort + ":3000/test",

I'm surprised it worked on gitpod, which is very picky about these things, and doesn't use ddev-router.

As gitpod is special in its port handling, I'll be more concrete:

ddev launch: opens https://8080-stasadev-ddev-ajl5zssk1i2.ws-eu110.gitpod.io (made sense to me)

ddev launch :3000: opens https://3000-stasadev-ddev-ajl5zssk1i2.ws-eu110.gitpod.io, not found (made sense to me)

ddev launch :3000/test: opens https://3000-stasadev-ddev-ajl5zssk1i2.ws-eu110.gitpod.io/test, not found (made sense to me)

Also:

gitpod /workspace/d10simple (main) $ DDEV_DEBUG=true ddev launch :3000 FULLURL http://127.0.0.1:3000 gitpod /workspace/d10simple (main) $ DDEV_DEBUG=true ddev launch :3000/test FULLURL http://127.0.0.1:3000/test

Thanks, I added more tests.

GuySartorelli · 2024-03-27T21:18:32Z

pkg/ddevapp/global_dotddev_assets/commands/host/launch

+  elif [[ $1 =~ ^: ]]; then
+    # specific port
+    FULLURL="${FULLURL%:[0-9]*}${1}";


What happens if the port is for http but the FULLURL is https? Or the other way around?

The protocol is not changed on ddev (might be redirected by e.g. nginx), so you can end on

400 Bad Request The plain HTTP request was sent to HTTPS port nginx

That's what I thought was probably the case.
It feels like this PR is missing a trick there. With the original PR (and the alternative I suggested) checking HTTP vs HTTPS and setting the correct port is managed, so we don't get into this situation.

Right now ddev launch has logic to check whether it should be using HTTP or HTTPS - but that logic isn't going to be leveraged here.

Looking at ddev adminer for example, there's just as much code figuring out what the URL should be (http vs https etc) as there is launching it. Ideally that could all be abstracted away together.

What happens if the port is for http but the FULLURL is https? Or the other way around?
It feels like this PR is missing a trick there.

Good point, thank you. I added detection for http/https.

Looking at ddev adminer for example, there's just as much code figuring out what the URL should be (http vs https etc) as there is launching it. Ideally that could all be abstracted away together.

The port for adminer can be shortened right now to (assuming someone is using DDEV v1.23.0-alpha1):

DDEV_ADMINER_PORT=9100 DDEV_ADMINER_HTTPS_PORT=9101 if [ ${DDEV_PRIMARY_URL%://*} = "https" ]; then ddev launch $DDEV_PRIMARY_URL:$DDEV_ADMINER_HTTPS_PORT else ddev launch $DDEV_PRIMARY_URL::$DDEV_ADMINER_PORT fi

or after this PR:

DDEV_ADMINER_PORT=9100 DDEV_ADMINER_HTTPS_PORT=9101 if [ ${DDEV_PRIMARY_URL%://*} = "https" ]; then ddev launch :$DDEV_ADMINER_HTTPS_PORT else ddev launch :$DDEV_ADMINER_PORT fi

But I'm not going to change it in the near future, because people can use the old DDEV with the new add-on version. And we have no restrictions on this. Ideally, add-ons should work like composer packages and pull only compatible add-on version, but at the moment that's probably too much work.

tyler36 · 2024-04-01T01:09:49Z

Maybe I'm missing something, but this works in 1.22.7, no?

$ ddev -v          
ddev version v1.22.7

$ DDEV_DEBUG=true ddev launch :8026
FULLURL https://tempest-l11-demo.ddev.site:8026

$ DDEV_DEBUG=true ddev launch $DDEV_PRIMARY_URL:3000
FULLURL https://tempest-l11-demo.ddev.site:3000

tyler36 · 2024-04-01T01:26:42Z

Please ignore my previous comment.

I updated to HEAD, played around and have now brew link back to a 1.22.7. I'm see the original issue as described and not seeing what I wrote above.

$ ddev -v
ddev version v1.22.7

$ DDEV_DEBUG=true ddev launch :8026
FULLURL https://tempest-l11-demo.ddev.site/:8026

Appologies for the false alarm.

stasadev · 2024-04-01T09:21:00Z

I'm see the original issue as described and not seeing what I wrote above.

I had a similar situation, the port worked for me at some point, and I added it to the documentation. But when I tried it later, it turned out that it didn't work at all.

tyler36

Tested on WSL2 (Ubuntu 22.04.4)

Current HEAD:

$ ddev -v
ddev version v1.23.0-alpha1

$ DDEV_DEBUG=true ddev launch :3000
FULLURL https://lara11-base-demo.ddev.site/:3000

This PR:

$ ddev -v
ddev version v1.23.0-alpha1-4-g71b07fb61

$ DDEV_DEBUG=true ddev launch :3000
FULLURL https://lara11-base-demo.ddev.site:3000

rfay

Thanks for the great work on this, and especially adding the extra cases to the test. It tests great manually and code is great. Thanks!

feat: accept port in ddev launch, for ddev#5525

cba5d15

stasadev requested review from a team as code owners March 27, 2024 17:22

github-actions bot added the enhancement label Mar 27, 2024

stasadev requested a review from tyler36 March 27, 2024 17:45

penyaskito reviewed Mar 27, 2024

View reviewed changes

GuySartorelli reviewed Mar 27, 2024

View reviewed changes

stasadev added 3 commits March 28, 2024 11:44

feat: detect http/https port

24c6740

docs: add a tip about HTTP to HTTPS redirect

6764425

test: fix link for http, use ddev describe

71b07fb

tyler36 reviewed Apr 4, 2024

View reviewed changes

stasadev mentioned this pull request Apr 5, 2024

docs: update FAQs on Chrome, large webserver, php-patch-build #6056

Merged

rfay approved these changes Apr 8, 2024

View reviewed changes

rfay merged commit 392b527 into ddev:master Apr 8, 2024
19 checks passed

stasadev deleted the 20240327_stasadev_launch_port branch April 10, 2024 11:07

rfay mentioned this pull request Apr 15, 2024

Add facility to make it easy to add launch type custom commands that open browser with correct URL #5518

Closed

1 task

tyler36 mentioned this pull request May 28, 2024

Refactor xhgui launch command ddev/ddev-xhgui#31

Merged

tyler36 mentioned this pull request Jun 7, 2024

DOCS: add launch by port ddev/ddev-selenium-standalone-chrome#45

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: accept port in `ddev launch`, for #5525 #6024

feat: accept port in `ddev launch`, for #5525 #6024

stasadev commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

penyaskito left a comment

penyaskito Mar 27, 2024

rfay Mar 27, 2024

penyaskito Mar 28, 2024

penyaskito Mar 28, 2024

stasadev Mar 28, 2024

GuySartorelli Mar 27, 2024 •

edited

Loading

penyaskito Mar 28, 2024

GuySartorelli Mar 28, 2024

GuySartorelli Mar 28, 2024 •

edited

Loading

stasadev Mar 28, 2024

stasadev Mar 28, 2024

tyler36 commented Apr 1, 2024

tyler36 commented Apr 1, 2024

stasadev commented Apr 1, 2024

tyler36 left a comment •

edited

Loading

rfay left a comment

	":3000": primaryURLWithoutPort + ":3000",
	":3000": primaryURLWithoutPort + ":3000",
	":3000/test": primaryURLWithoutPort + ":3000/test",

feat: accept port in ddev launch, for #5525 #6024

feat: accept port in ddev launch, for #5525 #6024

Conversation

stasadev commented Mar 27, 2024 • edited Loading

The Issue

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

github-actions bot commented Mar 27, 2024 • edited Loading

penyaskito left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuySartorelli Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuySartorelli Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tyler36 commented Apr 1, 2024

tyler36 commented Apr 1, 2024

stasadev commented Apr 1, 2024

tyler36 left a comment • edited Loading

Choose a reason for hiding this comment

rfay left a comment

Choose a reason for hiding this comment

feat: accept port in `ddev launch`, for #5525 #6024

feat: accept port in `ddev launch`, for #5525 #6024

stasadev commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 27, 2024 •

edited

Loading

GuySartorelli Mar 27, 2024 •

edited

Loading

GuySartorelli Mar 28, 2024 •

edited

Loading

tyler36 left a comment •

edited

Loading