Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up methods on Page #6

Closed
dellsystem opened this issue Jun 12, 2012 · 0 comments
Closed

Clean up methods on Page #6

dellsystem opened this issue Jun 12, 2012 · 0 comments

Comments

@dellsystem
Copy link
Member

There are a lot of them, and they are messy and don't all work properly.

@ghost ghost assigned dellsystem Jun 12, 2012
dellsystem added a commit that referenced this issue Jun 12, 2012
Because gamera has a tendency to segfault when encountering certain
scale factors that it doesn't like.

Also changed some of the image filename methods to return a JPEG and
not a PNG.

The current code is very messy and will definitely be cleaned up once
issue #6 has been resolved.
dellsystem added a commit that referenced this issue Jun 13, 2012
Comes with some tests (and fixes a bug in another test - see comments
on commit 0230ffe

A THUMBNAIL_EXT variable in settings.py is now used for the thumbnail
extension (currently jpg).

Stuff left to do:

* Fix the create_thumbnails method (rewrite it in accordance with these
  changes, etc)
* Better comments
* More tests!! Also, the rest of the code needs to be changed to account
  for the new methods (as necessary)
* See if there's a way of lowering the number of distinct methods
dellsystem added a commit that referenced this issue Jun 13, 2012
Issue #6 continued. SORRY ALASTAIR
@dellsystem dellsystem removed their assignment Apr 28, 2014
deepio pushed a commit that referenced this issue Jan 17, 2020
Add new hello world job supporting multiple ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant