Make the output machine readable #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…machine readable.
|
make sure to update the README as well. then i will check the commits |
|
Updated the README. |
|
Do you use |
ddo
reviewed
Nov 23, 2021
fast.go
Outdated
| for Kbps := range KbpsChan { | ||
| status = format(Kbps) | ||
| } | ||
| value,units = format(Kbps,kb,mb,gb) |
There was a problem hiding this comment.
this line should be:
value, units = format(Kbps, kb, mb, gb)if run go fmt?
|
I ran go fmt on |
|
thanks. will merge soon today |
|
will update snap and docker later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want the run the script as a batch job for monitoring purposes but the current output is difficult to read in a script. I converted the script to be more machine readable by
--silentswitch to suppress status output until the end-k,-m, and-gswitches to force output into kbps, mbps, or gbps respectively.This PR includes the go modernization changes written by musl's change request.