Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dotenv 0.11.x #437

Closed
wants to merge 1 commit into from
Closed

Conversation

seamusabshere
Copy link
Contributor

this is a less loose version of #436

0.11.x allows the use of dotenv-deployment which is a significant improvement over 0.7.x

this is a less loose version of ddollar#436 - 0.11.x allows the use of `dotenv-deployment` which is a significant improvement over 0.7.x
@seamusabshere
Copy link
Contributor Author

(it truncated my comment)

0.11.x allows the use of dotenv-deployment, which factors the very useful .env.{test,development,production} pattern out of the (now deprecated, I believe) dotenv-rails

@ddollar
Copy link
Owner

ddollar commented Apr 22, 2014

Breaking out internal functionality into a separate gem seems like a dotenv implementation detail that doesn't actually affect foreman. Could you please elaborate on why the bump is needed?

@seamusabshere
Copy link
Contributor Author

I want to make sure we're using the latest foreman because it has lots of great fixes, but I also want to use dotenv-deployment for non-rails apps:

Bundler could not find compatible versions for gem "dotenv":
  In Gemfile:
    foreman (>= 0.64.0) ruby depends on
      dotenv (~> 0.7.0) ruby

    dotenv (0.11.1)

@ddollar
Copy link
Owner

ddollar commented Apr 22, 2014

You should not put foreman into your Gemfile as the dependencies of a developer utility should not be able to interfere with the dependencies of your app.

@ddollar ddollar closed this Apr 22, 2014
@seamusabshere
Copy link
Contributor Author

ok, that's fair, I was following thoughbot convention:

https://github.com/thoughtbot/suspenders/blob/master/templates/Gemfile.erb

thanks @ddollar !

@ddollar
Copy link
Owner

ddollar commented Apr 22, 2014

Interesting I have always wondered where that trend got started. Having foreman be run inside the app using whatever random version of Ruby the user has installed is quite a pain point.

If you'd like to see something smaller with even less dependencies check out https://github.com/ddollar/forego

@seamusabshere
Copy link
Contributor Author

brilliant

seamusabshere added a commit to seamusabshere/suspenders that referenced this pull request Apr 29, 2014
seamusabshere added a commit to seamusabshere/foreman that referenced this pull request Apr 29, 2014
croaky pushed a commit to thoughtbot/suspenders that referenced this pull request Jul 11, 2014
Provide documentation in project's README and in `bin/setup`.

ddollar/foreman#437 (comment)
Koronen added a commit to Koronen/stringer that referenced this pull request Aug 31, 2014
> You should not put `foreman` into your `Gemfile` as the dependencies of a
> developer utility should not be able to interfere with the dependencies of
> your app.
<ddollar/foreman#437 (comment)>

> Ruby users should take care *not* to install foreman in their project's
> `Gemfile`.
<https://github.com/ddollar/foreman/blob/e53bf7f62f7d440fc9506ce53c5151dc4942f378/README.md#installation>
Koronen added a commit to Koronen/stringer that referenced this pull request Aug 31, 2014
> You should not put `foreman` into your `Gemfile` as the dependencies of a
> developer utility should not be able to interfere with the dependencies of
> your app.
<ddollar/foreman#437 (comment)>

> Ruby users should take care *not* to install foreman in their project's
> `Gemfile`.
<https://github.com/ddollar/foreman/blob/v0.68.0/README.md#installation>
Koronen added a commit to Koronen/stringer that referenced this pull request Aug 31, 2014
> You should not put `foreman` into your `Gemfile` as the dependencies of a
> developer utility should not be able to interfere with the dependencies of
> your app.
<ddollar/foreman#437 (comment)>

> Ruby users should take care *not* to install foreman in their project's
> `Gemfile`.
<https://github.com/ddollar/foreman/blob/v0.68.0/README.md#installation>
flada-auxv added a commit to flada-auxv/annict that referenced this pull request Jan 20, 2015
purinkle pushed a commit to purinkle/radfords that referenced this pull request Jun 19, 2015
Provide documentation in project's README and in `bin/setup`.

ddollar/foreman#437 (comment)
purinkle pushed a commit to purinkle/radfords that referenced this pull request Jun 19, 2015
Provide documentation in project's README and in `bin/setup`.

ddollar/foreman#437 (comment)
alexeyzab added a commit to alexeyzab/uchan that referenced this pull request Dec 31, 2015
buren added a commit to justarrived/just_match_api that referenced this pull request Jan 23, 2016
Web-Go-To added a commit to Web-Go-To/rails_suspenders that referenced this pull request Mar 23, 2023
Provide documentation in project's README and in `bin/setup`.

ddollar/foreman#437 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants