Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split node.js function to node-helper #63

Merged
merged 6 commits into from
Mar 12, 2020

Conversation

nogic1008
Copy link
Contributor

No description provided.

@nogic1008 nogic1008 added the refactoring ✨ Not a new feature (code clean, remove dup...) label Mar 12, 2020
@commit-lint
Copy link

commit-lint bot commented Mar 12, 2020

Code Refactoring

  • split process.env action to node-helper (aef39f1)
  • use Set (46fd2c8)
  • simplify isSupportedEvent() (263b0fe)

Build System

  • lint: add no-process-env & no-console rule (33d5cec)

Doc

  • add documentation comment (cb5c50a)

Tests

Contributors

@nogic1008

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #63 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines           59        60    +1     
  Branches        12         9    -3     
=========================================
+ Hits            59        60    +1     
Impacted Files Coverage Δ
src/event.ts 100.00% <100.00%> (ø)
src/input-helper.ts 100.00% <100.00%> (ø)
src/main.ts 100.00% <100.00%> (ø)
src/node-helper.ts 100.00% <100.00%> (ø)
src/send-comment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb0b7c...0a95d07. Read the comment docs.

@nogic1008 nogic1008 merged commit 787a460 into master Mar 12, 2020
@nogic1008 nogic1008 deleted the refactor/process-env branch March 12, 2020 05:13
@nogic1008 nogic1008 added this to the v1.1 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ✨ Not a new feature (code clean, remove dup...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant