Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: treat token parameter as optional #67

Merged
merged 5 commits into from
Mar 13, 2020
Merged

Conversation

nogic1008
Copy link
Contributor

close #66

@nogic1008 nogic1008 added the enhancement:speech_balloon: New feature or request label Mar 13, 2020
@nogic1008 nogic1008 added this to the v1.2 milestone Mar 13, 2020
@commit-lint
Copy link

commit-lint bot commented Mar 13, 2020

Features

  • set token param as optional (231ca6e)
  • get token parameter as optional (710f67f)

Doc

  • treat token param as optional in README (2832299)
  • treat token param as optional in README-ja (14570f7)

Bug Fixes

Contributors

@nogic1008

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #67 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           60        60           
  Branches         9         9           
=========================================
  Hits            60        60           
Impacted Files Coverage Δ
src/input-helper.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1386e...58252b2. Read the comment docs.

@nogic1008 nogic1008 merged commit 52f82da into master Mar 13, 2020
@nogic1008 nogic1008 deleted the feature/optional-token branch March 13, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:speech_balloon: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set ${{ github.token }} to token parameter as default
1 participant