Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Expand wildcard #502

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Makefile: Expand wildcard #502

merged 1 commit into from
Jul 25, 2023

Conversation

bunder
Copy link
Contributor

@bunder bunder commented Jul 24, 2023

Without this patch build fails with following error:

make: *** No rule to make target 'ddterm/app/icons/*', needed by '.../ddterm@amezin.github.com/ddterm/app/icons/*'.  Stop.

Without this patch build fails with following error:

  make: *** No rule to make target 'ddterm/app/icons/*', needed by '.../ddterm@amezin.github.com/ddterm/app/icons/*'.  Stop.
@amezin
Copy link
Member

amezin commented Jul 25, 2023

Weird. It builds successfully on my machine and in CI.

I can trigger this error only when ddterm/app/icons/ is empty. But it shouldn't be empty.

Oh, it also happens when installing system-wide, I see

@amezin amezin merged commit e871257 into ddterm:master Jul 25, 2023
9 of 11 checks passed
@bunder
Copy link
Contributor Author

bunder commented Jul 25, 2023

ddterm/app/icons is not empty on my machine. I have somewhat standard setup: Arch Linux, x86_64, bash, GNU Make 4.4.1.

But you're right: make should expand wildcards automatically, when they are used in rules. I don't know why this doesn't work.

@amezin
Copy link
Member

amezin commented Jul 25, 2023

But you're right: make should expand wildcards automatically, when they are used in rules. I don't know why this doesn't work.

At least for system-wide "make install", it happens because

SYS_INSTALLED_CONTENT := $(addprefix $(SYS_INSTALLED_FULL_PREFIX)/,$(PACK_CONTENT))

Wildcards won't work for "destination" files obviously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants