Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide asciidoctorj API dependencies at compile time #49

Closed
de-jcup opened this issue Apr 3, 2022 · 0 comments
Closed

Provide asciidoctorj API dependencies at compile time #49

de-jcup opened this issue Apr 3, 2022 · 0 comments
Assignees
@de-jcup
Milestone
1.3.2

Comments

@de-jcup
Copy link
Owner

de-jcup commented Apr 3, 2022 •
edited
Loading

Situation

Inside V1.4.0 the new Option builder API was introduced and the origin "just map" was removed inside ASPClient
Inside de-jcup/eclipse-asciidoctor-editor#371 the for asciidoctor editor plugin build is being changed from gradle (+manual parts) to full automated maven tycho.

The tycho build does currently work with asp 1.3.1 but ... the asciidoctorj dependencies are missing.
The changes done for 1.4.0 shall not be applied inside the maven-tycho branch but inside master branch.

So... as long as maven tycho branch is still under development, we rely on the API in 1.3.1 way.

Wanted

Having a version based on 1.3.1 but with compile dependencies to asciidoctorj api parts.

Solution

Provide Version 1.3.2 based on 1.3.1 without the changes done in 1.4.0 and publish it on maven central
@de-jcup de-jcup added this to the 1.3.2 milestone Apr 3, 2022
@de-jcup de-jcup self-assigned this Apr 3, 2022
@de-jcup de-jcup changed the title Bring back method Provide asciidoctorj dependencies at compile time Apr 3, 2022
@de-jcup de-jcup changed the title Provide asciidoctorj dependencies at compile time Provide asciidoctorj API dependencies at compile time Apr 3, 2022
de-jcup added a commit that referenced this issue Apr 3, 2022
@de-jcup
Made asciidoctorj api available at compile time #49
99e0005
@de-jcup de-jcup closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
1 participant
@de-jcup