Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option whether to build dealii examples #173

Merged
merged 1 commit into from May 20, 2021
Merged

Option whether to build dealii examples #173

merged 1 commit into from May 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2021

In my experience, building the dealii tutorials is quite time consuming and if one specific is needed it can be build on demand in a local workdir. So this option allows a flag whether to enable or disable the build of the dealii tutorials.

Personally, I would also be interested in how to set up the continuous integration for testing this (i.e. how to test both cases true|false).

@koecher
Copy link
Contributor

koecher commented May 20, 2021

Thanks. I like to have this option very much.

@koecher koecher merged commit 2c5ab5c into dealii:master May 20, 2021
@koecher
Copy link
Contributor

koecher commented May 20, 2021

@gfcas I maybe don't understand your question regarding CI, if you like to test, you can set up a local.cfg in which you change options and this file is not recognised by git.

@ghost
Copy link
Author

ghost commented May 20, 2021

@gfcas I maybe don't understand your question regarding CI, if you like to test, you can set up a local.cfg in which you change options and this file is not recognised by git.

@koecher thanks, that aswers the question completely! With git I have some small experience now, however, with CI I havent work until now.

@ghost ghost deleted the dealii_examples_option branch May 20, 2021 08:31
@ghost
Copy link
Author

ghost commented May 20, 2021

@gfcas I maybe don't understand your question regarding CI, if you like to test, you can set up a local.cfg in which you change options and this file is not recognised by git.

May I open a pr with a modified test? As I see it correctly I would have to modify the .github/workflow/main.yml file?

@koecher
Copy link
Contributor

koecher commented May 20, 2021

since @tjhei is managing the CI here, I would suggest to ask him.

@ghost ghost mentioned this pull request Jun 18, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant