Update package gmsh

[ghost]

This updates the gmsh version as the gitlab download is used. An updated of the version and the checksum for the tar.gz. download will follow. Either symengine #198 or this has to be merged, afterwards I have to rebase this or #198.

[koecher]

#198 is merged now

[koecher]

Does it make sense to keep all the old comments and configs from v3 (and v2) for the current v4.8?
Maybe we should split to gmsh-v3.package (with the old config) and gmsh.package for the current version.

[ghost]

As you prefer ... Creating an extra file is no problem. Do we want to create an extra directory with 'deprecated' package files, similar to the platform files?
The CI in my fork (gmsh+dealii and cmake+hdf5+dealii) were all successful. In particular, it was possible to use the cmake 3.20.4 version, which is the default on the github actions runners, see for example
https://github.com/gfcas/candi/actions/runs/969075570

[ghost]

Does it make sense to keep all the old comments and configs from v3 (and v2) for the current v4.8?
Maybe we should split to gmsh-v3.package (with the old config) and gmsh.package for the current version.

@tjhei what do you think?

[tjhei]

I am not sure I understand what you want to keep. I don't see what is different or worth keeping. Can you elaborate?

[tjhei]

Looks good.

[koecher]

A snap. Forgot to submit my review yesterday.
Since the option for slepc:off isn't used, this comment doesn't make sense.

[koecher]

I merge this here and push an update

[ghost]

I merge this here and push an update

Thanks @koecher!