-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian 10 as supported platform and add missing package for SymEngine #238
Conversation
It looks like the two platform files (debian9, debian10) are identical except for the version numbers. Since we just merged the different platforms for Fedora and Ubuntu, we could do the same for Debian. @koecher What do you think? @Sebastian-47 If you rename one of the Debian platform files to debian.platform, remove the other one and replace in candi.sh line 633 |
Yes, the two platform files were identical. Therefore, I have unified both files as you suggested. |
@@ -1,4 +1,4 @@ | |||
# debian 9 | |||
# debian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debian Debian
# | ||
# Then reboot and run candi again. | ||
## | ||
|
||
# on debian 9 the candi installed parmetis 4.0.3 is not recognized correctly | ||
# on debian the candi installed parmetis 4.0.3 is not recognized correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on debian On Debian
# | ||
# Then reboot and run candi again. | ||
## | ||
|
||
# on debian 9 the candi installed parmetis 4.0.3 is not recognized correctly | ||
# on Debian the candi installed parmetis 4.0.3 is not recognized correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On (capitalized beginning of sentence ... sorry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just missed that.
@Sebastian-47 Maybe you also want to squash your commits into one single commit. You can do this for example with:
Maybe you are more familiar with git and dont need this. In any case you also want to do a backup of the updated files during theses steps ;) |
Squashing can be done as merging strategy in github itself (currently). So there is no need for it here, but thanks for the remark. |
@Sebastian-47 Thank you for your contribution. Just a general remark: it would be great if you can create different pull requests if you have different developments, e.g. here the symengine / centos and the debian platform. |
@Sebastian-47 Another remark: it would be good if you branch ( |
I added Debian 10 as supported platform and tested if it works.
I also noticed that for the platforms CentOS 7 and Debian 9, the package for SymEngine (i.e. gmp-devel and libgmp-dev respectively) is missing. Therefore, I added these packages.
Furthermore I guess that the package for SymEngine is also missing on other platforms, but I can only test CentOS and Debian at the moment.