Skip to content

Commit

Permalink
Fix the polynomial degree the ABF element reports about itself.
Browse files Browse the repository at this point in the history
As stated in the original paper (http://www-users.math.umn.edu/~arnold/papers/vecquad.pdf),
section 5, and as also stated in our discussion of the PolynomialsABF element, the
ABF space of order 'r' actually contains polynomials of degree 'r+2'. Report this
accurately.

Without this, the computation of embedding matrices fails in 3d because we integrate
the least squares matrix terms with a quadrature formula of too low order.
  • Loading branch information
bangerth committed Jan 13, 2017
1 parent fd1a09a commit e8180bc
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion source/fe/fe_abf.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ FE_ABF<dim>::FE_ABF (const unsigned int deg)
FE_PolyTensor<PolynomialsABF<dim>, dim> (
deg,
FiniteElementData<dim>(get_dpo_vector(deg),
dim, deg+1, FiniteElementData<dim>::Hdiv),
dim,
deg+2,
FiniteElementData<dim>::Hdiv),
std::vector<bool>(PolynomialsABF<dim>::compute_n_pols(deg), true),
std::vector<ComponentMask>(PolynomialsABF<dim>::compute_n_pols(deg),
std::vector<bool>(dim,true))),
Expand Down

0 comments on commit e8180bc

Please sign in to comment.