Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distribution of levels in pft #10453

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Jun 3, 2020

closes #10449.


DEAL:0:2d::93274

DEAL:1:2d::121820
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have made the experience that the output of the memory consumption as a plain number is a pain to maintain because the result depends on the number type (32 vs 64 bit integers), changes somewhere in the code that lead to different allocated sizes, or also different implementations of the STL library in terms of how to dynamically grow vectors. Can we find a way to approximately control this number, say, by checking that it is in the right range (and assert that this is the case at least for 32 and 64 bit builds)?

Comment on lines +63 to +64
Assert((min_max_avg.min / min_max_avg.max >= 0.75),
ExcMessage("Memory consumption difference is too big!"));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kronbichler Good point! What about this solution?

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

main(int argc, char *argv[])
{
Utilities::MPI::MPI_InitFinalize mpi_initialization(argc, argv, 1);
MPILogInitAll all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we do not need to the specific output any more, how about:

Suggested change
MPILogInitAll all;
mpi_initlog();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@agrayver
Copy link
Contributor

Can this be merged?

@peterrum
Copy link
Member Author

I don't want to merge my own PR! Anyone?

@kronbichler kronbichler merged commit 15ab75e into dealii:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory consumption of p::f::t
3 participants