Move some class declarations into the .h file. #10454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one test that has not completed appears spurious. All the other tests succeed. |
|
Just for clarification: |
drwells
approved these changes
Jun 4, 2020
|
@drwells Correct. We currently have one global such object, declared and defined in the |
|
I think you meant to @masterleinad there. |
masterleinad
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step in my quest to fix #10284. I need to create one of these cache objects in the
AffineConstraintsclass, so the cache class (and everything that is referenced in it) needs to be in the.hfile.No functional changes, just moving stuff from one file to another.
/rebuild