Add more python wrappers for GridTools #10875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrayver
force-pushed
the
python_wrappers
branch
from
594e5a2
to
692012c
Compare
Rombur
reviewed
Sep 3, 2020
| GridGenerator::merge_triangulations(*tria_1, *tria_2, *tria); | ||
| // We need to reassign tria to triangulation because tria was cleared | ||
| // inside merge_triangulations. | ||
| triangulation = tria; |
There was a problem hiding this comment.
So this part is not necessary anymore?
There was a problem hiding this comment.
This is what happens inside
dealii/source/grid/grid_generator.cc
Line 5976 in e9461de
Gigen that we pass the argument by reference, I don't see a need for this. Am I missing something?
Rombur
reviewed
Sep 3, 2020
| more general version of the GridTools::merge_triangulations is | ||
| implemented | ||
| <br> | ||
| (Alexander Grayver, 2020/09/01) |
There was a problem hiding this comment.
You technically also introduce an incompatibility in merge_triangulation So can you add an entry there.
|
/rebuild |
|
Thanks, @Rombur! I added an incompatibility note. Also, I added two optional parameters of the original C++ function to the python wrapper. |
Rombur
approved these changes
Sep 9, 2020
agrayver
force-pushed
the
python_wrappers
branch
from
fc7ecc9
to
d80a06e
Compare
|
@Rombur should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge_triangulationswrapper that accepts only two triangulations with a more generic equivalent.Part of #9015