New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python method for number of triangulation cells #10885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrayver
force-pushed
the
python_cell_wrapper
branch
from
September 3, 2020 14:35
d1bf315
to
38301c3
Compare
Rombur
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
static_cast<Triangulation<dim, spacedim> *>( | ||
triangulation_wrapper.get_triangulation()); | ||
boost::python::list cells_list; | ||
for (auto &cell : tria->cell_iterators()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
for (auto &cell : tria->cell_iterators()) | |
for (const auto &cell : tria->cell_iterators()) |
clang-format is failing |
agrayver
force-pushed
the
python_cell_wrapper
branch
from
September 15, 2020 10:40
38301c3
to
3eaaa80
Compare
Should be fixed now. |
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rebased against #10875, hence only last commit is relevant.
Part of #9015