Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python method for number of triangulation cells #10885

Merged
merged 5 commits into from Sep 15, 2020

Conversation

agrayver
Copy link
Contributor

@agrayver agrayver commented Sep 3, 2020

Currently rebased against #10875, hence only last commit is relevant.

Part of #9015

Copy link
Member

@Rombur Rombur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

static_cast<Triangulation<dim, spacedim> *>(
triangulation_wrapper.get_triangulation());
boost::python::list cells_list;
for (auto &cell : tria->cell_iterators())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (auto &cell : tria->cell_iterators())
for (const auto &cell : tria->cell_iterators())

@Rombur
Copy link
Member

Rombur commented Sep 9, 2020

clang-format is failing

@agrayver
Copy link
Contributor Author

clang-format is failing

Should be fixed now.

@Rombur
Copy link
Member

Rombur commented Sep 15, 2020

/rebuild

@masterleinad masterleinad merged commit 96c7f7a into dealii:master Sep 15, 2020
@agrayver agrayver deleted the python_cell_wrapper branch September 16, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants