Added Triangulation::create_cell_iterator(). #11365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
to-cell
branch
3 times, most recently
from
de620e0
to
e3e673a
Compare
peterrum
approved these changes
Dec 13, 2020
bangerth
reviewed
Dec 13, 2020
| @@ -2743,6 +2744,13 @@ class Triangulation : public Subscriptor | |||
| active_cell_iterator | |||
| last_active() const; | |||
|
|
|||
| /** | |||
| * Return an iterator to a cell of this Triangulation object constructed from | |||
| * an independent CellId object. | |||
There was a problem hiding this comment.
Maybe add a sentence like this:
Suggested change
| * an independent CellId object. | |
| * an independent CellId object. If the given argument corresponds to a valid | |
| * cell in this triangulation, this operation will always succeed for sequential | |
| * triangulations where the current processor stores all cells that are part | |
| * of the triangulation. On the other hand, if this is a parallel triangulation, | |
| * then the current processor may not actually know about this cell and in this | |
| * case ... |
- add what actually happens. I suspect that the operation is ok if it's a locally owned or ghost cell, but may not work if it's an artificial cell. Maybe say so.
There was a problem hiding this comment.
I suspect so, too. Artificial cells may not be refined enough to create a cell iterator. I've adjusted the documentation and the error message accordingly.
|
/rebuild |
tjhei
approved these changes
Dec 13, 2020
kronbichler
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
Looks good to me once we have agreed on a solution for #11364.
|
Rebased on master. Ready for final review/merge. |
bangerth
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11362.
Blocked by #11364.(EDIT: merged)