Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CellId::to_cell #14070

Merged
merged 2 commits into from Jun 29, 2022
Merged

Conversation

masterleinad
Copy link
Member

Deprecated in #11365.

@marcfehling
Copy link
Member

You also need to get rid of the explicit instantiations:

for (deal_II_dimension : DIMENSIONS; deal_II_space_dimension : SPACE_DIMENSIONS)
{
#if deal_II_dimension <= deal_II_space_dimension
template Triangulation<deal_II_dimension,
deal_II_space_dimension>::cell_iterator
CellId::to_cell(
const Triangulation<deal_II_dimension, deal_II_space_dimension> &tria)
const;
#endif
}

Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Did you grep all tests?

@masterleinad
Copy link
Member Author

Looks good, thank you. Did you grep all tests?

Yes.

@peterrum peterrum merged commit 319be96 into dealii:master Jun 29, 2022
mkghadban pushed a commit to OpenFCST/dealii that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants