Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GridReordering::reorder_cells(). #12082

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

drwells
Copy link
Member

@drwells drwells commented Apr 22, 2021

Fixes #12058. This was easier than I thought it would be - the second GridReordering function already used the new-style numbering internally.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the code is simply copied without actual changes?

@drwells
Copy link
Member Author

drwells commented Apr 22, 2021

Yup!

@drwells drwells force-pushed the remove-gridreordering-3 branch 2 times, most recently from 3a147ca to b8f0a49 Compare April 22, 2021 18:52
@bangerth
Copy link
Member

Hm, the testers fail:

/home/runner/work/dealii/dealii/include/deal.II/grid/grid_reordering.h:37:32: error: attribute ignored in declaration of ‘class dealii::GridReordering<dim, spacedim>’ [-Werror=attributes]
 DEAL_II_DEPRECATED_EARLY class GridReordering
                                ^~~~~~~~~~~~~~
/home/runner/work/dealii/dealii/include/deal.II/grid/grid_reordering.h:37:32: note: attribute for ‘class dealii::GridReordering<dim, spacedim>’ must follow the ‘class’ keyword

So it's a placement thing for the attribute.

@drwells
Copy link
Member Author

drwells commented Apr 22, 2021

I can never remember where these things go - it should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all public-facing references to the old-style ordering
3 participants