Remove deprecated functions in GridReordering #15611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jul 3, 2023
Comment on lines
-28
to
-38
| /** | ||
| * A class implementing various grid reordering algorithms. For more information | ||
| * see the | ||
| * @ref reordering "reordering module". | ||
| * | ||
| * @deprecated Use GridTools::invert_all_negative_measure_cells() or | ||
| * GridTools::consistently_order_cells() instead of the functions provided by | ||
| * this class. Usage of the old-style numbering is deprecated. | ||
| */ | ||
| template <int dim, int spacedim = dim> | ||
| class GridReordering |
There was a problem hiding this comment.
It's unfortunate that we didn't mark this class as deprecated, nor that we poisoned the header file. Any thoughts?
There was a problem hiding this comment.
I think it is ok to delete this function, given that all functions in the class were deprecated before.
|
/rebuild |
tamiko
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in #12071 and #12082.