Fix manifold copying on lines when converting hexes to tets. #13192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
drwells
changed the title
drwells
force-pushed
the
fix-manifold-id-simplex-copy
branch
from
ab6c4cb
to
eba9538
Compare
bangerth
reviewed
Jan 8, 2022
|
Maybe also a changelog entry? |
When we convert hexes to tets, we create three types of lines: 1. lines inside the hex 2. lines on the faces of the hex 3. lines equal to the hex's lines In the last case we need to copy the manifold and boundary data from the preexisting lines directly, since they may not be equal to the ids assigned to the adjacent face.
drwells
force-pushed
the
fix-manifold-id-simplex-copy
branch
from
eba9538
to
bdf23d6
Compare
|
Fixed! |
bangerth
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13040.
When we convert hexes to tets, we create three types of lines:
In the last case we need to copy the manifold and boundary data from the preexisting lines directly, since they may not be equal to the ids assigned to the adjacent face.
Here's a picture of the bug in action. The top cell gets assigned a flat manifold id along one edge from the flat face instead of the curved face, so refinement produces the wrong result:
fixed version with this patch:
