Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manifold copying on lines when converting hexes to tets. #13192

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Fix manifold copying on lines when converting hexes to tets. #13192

merged 3 commits into from
Jan 10, 2022

Commits on Jan 7, 2022

  1. Modify a test to show a bug.

    @drwells
    drwells committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    0e0d653 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. Fix a bug where line manifold ids were not copied correctly. 

    When we convert hexes to tets, we create three types of lines:
1. lines inside the hex
2. lines on the faces of the hex
3. lines equal to the hex's lines

In the last case we need to copy the manifold and boundary data from the
preexisting lines directly, since they may not be equal to the ids assigned to
the adjacent face.
    @drwells
    drwells committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    1db3f57 View commit details
    Browse the repository at this point in the history

  2. Add another test that shows some vertex displacement.

    @drwells
    drwells committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    bdf23d6 View commit details
    Browse the repository at this point in the history